`h0` script improvements

Seagate / halon

High availability solution

Apache License 2.0

1 stars 0 forks source link

`h0` script improvements #1576

Closed vvv closed 5 years ago

vvv commented 5 years ago

Rename Halon log files (/var/log/halon.{decision,trace}.log) in h0 fini — add _preserved-for-debugging suffix. h0 init won't overwrite those files. The suffix makes it easy to differentiate old logs from current ones.
Simplify halon-cleanup script: --keep-logs option is not needed any more.

vvv commented 5 years ago

merged

andriytk commented 5 years ago

assigned to @vvv

andriytk commented 5 years ago

Looks good.

vvv commented 5 years ago

assigned to @andriy.tkachuk

vvv commented 5 years ago

changed the description

vvv commented 5 years ago

changed title from {-scripts/h0 (cmd_init): clean Halon log-}s to {+h0 script improvement+}s

vvv commented 5 years ago

added 9 commits

96288cd0...5be5622e - 6 commits from branch master
0c515774 - scripts/h0: don't set environment variable twice
da54a017 - scripts/h0 (cmd_init): clean Halon logs
2496354b - scripts/h0 (cmd_fini): preserve logs for debugging

Compare with previous version

vvv commented 5 years ago

added 1 commit

96288cd0 - scripts/h0 (cmd_fini): preserve logs for debugging

Compare with previous version

vvv commented 5 years ago

changed the description

vvv commented 5 years ago

Good idea! See what I made of it: 96288cd0f16429d00cdbe8227db51f85639a5032.

vvv commented 5 years ago

added 9 commits

3bca8d86...ba4c9b52 - 6 commits from branch master
6d6b28f9 - scripts/h0: don't set environment variable twice
2395af5f - scripts/h0 (cmd_init): clean Halon logs
2bb2a1f5 - scripts/h0 (cmd_fini): preserve logs for debugging

Compare with previous version

andriytk commented 5 years ago

assigned to @vvv

andriytk commented 5 years ago

Sometimes there is a need to compare the log with the previous run and you forget to save the log from that previous session. So instead of the deletion, I'd propose to just rename the /var/log/halon.{decision,trace}.log files to something like - /var/log/halon.{decision,trace}-old.log.

Does it make sense?