search

Seagate / halon

High availability solution
Apache License 2.0
1 stars 0 forks source link

ci: speedup multi-node test #1581

Closed andriytk closed 5 years ago

andriytk commented 5 years ago

By killing m0d also (along with halond) in the test we avoid odd Stopping->Starting cycle for m0d.

vvv commented 5 years ago

Ah, I see.

andriytk commented 5 years ago

closed

andriytk commented 5 years ago

Killing Halon and Mero processes is slightly different scenario.

Fair point.

andriytk commented 5 years ago

That backslash is because of ssh.

vvv commented 5 years ago

pkill(1):

OPERANDS
       pattern
              Specifies an Extended Regular Expression  for  matching  against
              the process names or command lines.

'halond\|m0d' is a basic regular expression. If the documentation is right, sudo pkill -9 'halond\|m0d' will kill neither halond nor m0d.

$ echo $'halond\nm0d' | egrep 'halond\|m0d'
$ echo $'halond\nm0d' | egrep 'halond|m0d'
halond
m0d
vvv commented 5 years ago

This ST runs “Failure of a satellite halond” scenario. Killing Halon and Mero processes is slightly different scenario.

My concern is that by killing halond and m0d processes we are making it easier for our software to pass the test. Real-life failures are not developer-friendly.

andriytk commented 5 years ago

assigned to @vvv

andriytk commented 5 years ago

changed the description

andriytk commented 5 years ago

added 1 commit

Compare with previous version