search

Seagate / halon

High availability solution
Apache License 2.0
1 stars 0 forks source link

HALON-260: Introduce halonctl cluster bootstrap command #783

Closed 1468ca0b-2a64-4fb4-8e52-ea5806644b4c closed 8 months ago

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

LGTM

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

Successfully bootstrapped on a cluster.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

Addressed comments, not tested on a cluster, yet.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

I don't think so, really. Per Halon both clients and servers are very similar - it's really only for SSPL purposes that we distinguish them. So I think satellite with remain the general term.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

Afaiu this is temporary requirement that should go away in future, right? So I mean satellite is the thing that should be definitely called by halond, but right server is fine here.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

Because I have forgot that!! (or forgot to push)

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

Right, though I think we need more clear solution here..

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

Ok

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Sure. I don't think we need to address as part of this PR.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Right, but to start a client, we have to call halonctl bootstrap satellite. So I just think the terminology is unclear.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

I think we need to gather requirements for halon description and create file to describe that. HalonConfig is intended to be passed as a file in future.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

We have clear distinction between clients and satellites. And there is an option to not start clients.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Review done, mostly minor naming issues, plus a couple of questions and one "will need to be done at some point".

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Any reason why not? Looks like you could just add it to ValidatedConfig...

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Move these timeouts to config, with a default there?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Parse the config here in the same way, for consistency?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Could do this as a separate PR, though.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

This is probably fine for now, but we will need to introduce an additional role for this, I think (may need 'halon roles' rather than 'mero roles'), since we will want multiple station nodes and Mero does not yet support multiple confds. We could then move the "default configuration" from being hardcoded in this file to being specified in the role maps file.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Seems badly named, as clients are also satellites. (clients, servers)?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

lnidToIP?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Rename this? takeString is very generic. takeIP, perhaps?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: qnikst

Ok, those are fqdn and IP address.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 8 years ago

Created by: nc6

Maybe document these parameters? What are these arrays of pairs of strings of?

shailesh-vaidya commented 8 months ago

Closing as an obsolete