search

Seagate / openSeaChest

Cross platform utilities useful for performing various operations on SATA, SAS, NVMe, and USB storage devices.
Other
436 stars 60 forks source link

feat: support for SCT error recovery in latest ACS #122

Closed wangru-stx closed 7 months ago

wangru-stx commented 9 months ago

This includes changes for FDOPENSRCE-289.

  1. Seagate/opensea-transport#19 and Seagate/opensea-operations#13 needs to be merged first and submodules need update to pull in these changes,
  2. The default behavior of --sctReadTimer and sctWriteTimer will be changed from volatile to non-volatile. Because we always default --volatile to false. The only solution is to use a different flag, for example keep --sctReadTimer for volatile but add --nonVolatileSctReadTimer for non-volatile. But that adds extra complexity.
wangru-stx commented 9 months ago

@DebabrataSTX Could you please help check this PR?

vonericsen commented 8 months ago

I will take a look at this sometime this week

vonericsen commented 7 months ago

@wangru-stx, Sorry for the delay looking at this, but I have finished reviewing it and merged in the changes. Thanks for adding these in!