search

Seagate / propeller

Customized lvmlockd
GNU General Public License v2.0
4 stars 7 forks source link

Changes for rpm and deb packaging #141

Closed lynetteneo closed 2 years ago

lynetteneo commented 3 years ago

Additional changes to the spec file. Added debian files for debian packaging for Ubuntu. Includes previous changes to Makefile. For the previous mention of installing of service file in src/Makefile, there doesn't seem to be any issue when installing from the Makefile for Centos 7, Redhat 7, OpenSUSE Leap 15.2, or Ubuntu 18.04. These are the ones I've tried installing on and didn't face any issue running the Makefile to install the services. So I'm keeping the installing of the service file in src/Makefile instead of moving them to the spec file.

Signed-off-by: lynetteneo lynette.sy.neo@seagate.com

Leo-Yan commented 3 years ago

Hi @lynetteneo, the changes look good to me, except I give a suggestion for how to dynamically generate version number and release tag based on the VERSION file and git tag.

@daniel-thompson could you give a review and shall we ask any Linaro colleague with releasing expertise to give a review, especially for the Debian releasing files?