Make fast kronecker matvec behavior more intuitive

SealUofI / SemPy

Simple Spectral Element Examples in Python

BSD 3-Clause "New" or "Revised" License

9 stars 1 forks source link

Make fast kronecker matvec behavior more intuitive #10

Open nchristensen opened 1 year ago

nchristensen commented 1 year ago

The existing behavior was based on a Matlab script, but is unintuitive for Python. (I think it has something to do with Matlab using F ordering.) The order of the arguments should also by Sx, Sy, Sz rather than Sz, Sy, Sx to match the standard mathematical notation $S_x \otimes S_y \otimes S_z$

nchristensen commented 1 year ago

We should probably also change the function name to avoid collision with Scipy's and Numpy's kron.