unexpected result using rank-2 generator

SeanArchibald / scale-workshop

Design microtonal scales and play them in your web browser. Export your scales for use with VST instruments. Convert Scala files to various tuning formats.

https://sevish.com/scaleworkshop/

146 stars 23 forks source link

unexpected result using rank-2 generator #129

Closed SeanArchibald closed 3 years ago

SeanArchibald commented 3 years ago

Using n-of-edo as a generator and selecting something non-default for Up/Down causes an unexpected result. Reproducible on develop branch - https://sevish.com/scaleworkshop-dev I'll update here as I do more testing.

rank-2-issue

vsicurella commented 3 years ago

Sorry, and thanks for catching this. My tests for "transposeSelf" are missing negative transpositions, which happen to not work for a few cases. I'll remedy this now!

vsicurella commented 3 years ago

I had forgotten to add proper negative handling to transposeSelf and moduloLine - but I'm about to submit a PR that fixes this.

SeanArchibald commented 3 years ago

working well for me. merged your PR :)