search

SeanArchibald / scale-workshop

Design microtonal scales and play them in your web browser. Export your scales for use with VST instruments. Convert Scala files to various tuning formats.
https://sevish.com/scaleworkshop/
146 stars 23 forks source link

fixed some issues with MOS mode in Subset #139

Closed vsicurella closed 3 years ago

vsicurella commented 3 years ago

This fixes the Issue #138. It seemed better to request this on the master branch since there seems to be a few new things on develop.

SeanArchibald commented 3 years ago

Is it possible to merge this into develop branch? Even if I have to manually sort through any merge conflicts, I would prefer that so there's no risk of me accidentally deploying it to the production environment. My usual pattern is to do all development work on the develop branch and only merge to master when there's a new release. Hopefully there won't be any conflicts anyway because we've been mostly working on different parts of the codebase.

vsicurella commented 3 years ago

Sure! Sorry, I had assumed we might want to push the fix sooner than later.

SeanArchibald commented 3 years ago

Thanks, I'll look at this as soon as I can (likely the weekend)!