search

SeanDaBlack / AbBOT

308 stars 55 forks source link

Improvements to readability, randomization and list population. #20

Closed Digital-Black closed 3 years ago

Digital-Black commented 3 years ago

Implemented randomization inside .join methods to generate random numbers for every report. Added to list populations to increase the number of total unique reports generated by an unknown population. Minor improvements to readability.

ramblingjordan commented 3 years ago

This is good work! I think because we've made a major code change with @andria-dev 's work this would still be useful but needs to be integrated into their code. Can you pull the current main or python-script branch and make the changes for that?

I'll leave this open for now.

Thanks again!!!

Digital-Black commented 3 years ago

No problem, I've entered the pull request and am ready to apply the same changes to the upstream main.

Digital-Black commented 3 years ago

Requested changes are implemented and a new pull request has been issued as I wasn't sure if another pull could be requested here. List randomization methods were not included as I haven't fully tested to determine whether they're necessary following commits by others.