SeanFeldman / ServiceBus.AttachmentPlugin

Microsoft Azure Service Bus attachment plugin
MIT License
68 stars 19 forks source link

Upgrade to Azure.Messaging.ServiceBus #201

Open SeanFeldman opened 4 years ago

SeanFeldman commented 4 years ago

Update 2023-02-11 Azure.Messaging.ServiceBus SDK's approach to plugins has been refreshed. Details in the comment.

Update 2020-06-26: blocked by the Azure SDK team's decision to introduce plugins post GA.

Azure Service Bus track 2 SDK is in preview and doesn't support pipelines and plugins yet.

Requires Preview 4 / https://github.com/Azure/azure-sdk-for-net/issues/11986 to be completed first.

SeanFeldman commented 4 years ago

Blocked by the Azure SDK team's decision to introduce plugins post GA. The API is internalized and won't be available.

basilfx commented 2 years ago

Just for your information: at work, we have updated to Azure Functions V4. I have upgraded most of this package to work with the new SDK: https://github.com/basilfx/ServiceBus.AttachmentPlugin/tree/feature/azure_messaging_servicebus

Yes, this branch does not include the plugin capability, but we were not using it anyway (because of Azure Functions).

SeanFeldman commented 2 years ago

@basilfx I'm no longer actively maintaining this project given the large message support provided officially by Microsoft. I also haven't seen any issues raised about it. A new major version could be released with a smaller API surface if you'd like to create a PR. API documentation would need to be updated to reflect the change.

SeanFeldman commented 1 year ago

Azure.Messaging.ServiceBus SDK's approach to plugins has been refreshed. The new approach achieves extensibility via inheritance, requiring plugin implementors to extend every ASB SDK type that would require the plugin to work (ServiceBusSender, ServiceBusSenderReceiver, ServiceBusProcessor, ServiceBusSessionReceiver, and ServiceBusSessionProcessor.

Here's a sample that demonstrates what an end-user experience would look like. cc @valdisiljuconoks

ankitvijay commented 1 year ago

Hi @SeanFeldman, we would love to have this feature available as an Azure Service Bus plugin. We use NSB over an ASB. Here's why we are looking for this feature for my team:

I hope the plugin would allow us to set the retention policy of external storage (I'm assuming it will be blob) and the naming convention of the blob name.

This issue ](https://github.com/Particular/NServiceBus/issues/6675) is stopping us from the NSB DataBus feature. So if the issue is fixed, perhaps we would not need this plugin anymore? (Not sure if the plugin would provide any additional features)