SeanHoWB / pe

0 stars 0 forks source link

Ability to remove negative values #10

Open SeanHoWB opened 2 years ago

SeanHoWB commented 2 years ago

image.png

Steps to recreate: Integer overflow 1) add ug/ sku/WC4 n/Wooden Chair d/Chair made of oak from Europe size/Medium 2) add g/ sku/WC4 qty/1000000000 3) add g/ sku/WC4 qty/2000000000 4) list g/ (if nothing shown, intger overflow is successful remove negative 5) remove g/ sku/WC1 qty/-2000000000

nus-se-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Integer Overflow

image.png

When adding the quantity beyond the limit of an integer, the program does not show the warehouse item.

image.png

furthermore any further adding of quantity does not show in the terminal

image.png

JSON file for proof of integer overflow


[original: nus-cs2113-AY2122S2/pe-interim#990] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi thanks for the feedback, we agree that this is an issue, however these values are much larger than reasonably expected for the warehouse to hold.

image.png

According to the module website this is considered as extreme user behaviour which should be rejected.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]