Open SeanHoWB opened 2 years ago
Thank you for your response. This is a problem of integer overflow which will be linked to the other bug found, and we lowered the severity because we believe that the problem is not something that affects the workings of the application to a large extent.
[The team marked this bug as a duplicate of the following bug]
Integer Overflow
When adding the quantity beyond the limit of an integer, the program does not show the warehouse item.
furthermore any further adding of quantity does not show in the terminal
JSON file for proof of integer overflow
[original: nus-cs2113-AY2122S2/pe-interim#990] [original labels: type.FunctionalityBug severity.High]
[This is the team's response to the above 'original' bug]
Hi thanks for the feedback, we agree that this is an issue, however these values are much larger than reasonably expected for the warehouse to hold.
According to the module website this is considered as extreme user behaviour which should be rejected.
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: Although this is also an integer overflow, because this application does not limit the order of numbering the oid, we cannot assume that order id goes sequentially from 1 to 2 billion.
Furthermore warehouses can have naming conventions of more than 10 digits. Orders can have separate fields denoting the time, date, location that the order. Hence, application should accomodate for larger order ids
Attached is an example of oid used in real life, with the linked website.
https://parcelsapp.com/en/shops/shopee
Team chose [response.Rejected
]
Reason for disagreement: same as duplicate status
Team chose [type.FunctionalityBug
]
Originally [type.FeatureFlaw
]
Reason for disagreement: [replace this with your explanation]
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: same as duplicate status