search

SeanJM / atom-css-clean

A plugin for Atom which sorts and aligns CSS and SASS
MIT License
20 stars 2 forks source link

Uncaught TypeError: settings.getTab is not a function #33

Closed johnosullivan closed 7 years ago

johnosullivan commented 7 years ago

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.16.0 x64 Electron: 1.3.13 OS: Mac OS X 10.12.3 Thrown From: atom-css-clean package 2.19.6

Stack Trace

Uncaught TypeError: settings.getTab is not a function

At /Users/johnosullivan/.atom/packages/atom-css-clean/node_modules/css-clean/src/main/getValue/modules/commentBlock.js:111

TypeError: settings.getTab is not a function
    at formatSpecialComment (/packages/atom-css-clean/node_modules/css-clean/src/main/getValue/modules/commentBlock.js:111:24)
    at /packages/atom-css-clean/node_modules/css-clean/src/main/getValue/modules/commentBlock.js:153:12)
    at /packages/atom-css-clean/node_modules/css-clean/src/main/getValue/modules/mapValue.js:26:30
    at Array.map (native)
    at mapValue (/packages/atom-css-clean/node_modules/css-clean/src/main/getValue/modules/mapValue.js:25:17)
    at getValue (/packages/atom-css-clean/node_modules/css-clean/src/main/getValue/getValue.js:4:10)
    at cleanCss (/packages/atom-css-clean/node_modules/css-clean/index.js:19:10)
    at module.exports (/packages/atom-css-clean/node_modules/css-clean/index.js:23:10)
    at /packages/atom-css-clean/main.js:43:17)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/app.asar/src/command-registry.js:259:29)
    at CommandRegistry.handleCommandEvent (/app.asar/src/command-registry.js:3:59)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (/app.asar/src/command-registry.js:160:19)
    at AtomEnvironment.module.exports.AtomEnvironment.dispatchApplicationMenuCommand (/app.asar/src/atom-environment.js:1179:28)
    at EventEmitter.outerCallback (/app.asar/src/application-delegate.js:312:25)
    at emitThree (events.js:116:13)
    at EventEmitter.emit (events.js:194:7)

Commands

     -0:26.8.0 css-clean:convert (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:22.8.0 core:select-all (input.hidden-input)
     -0:19.6.0 css-clean:convert (input.hidden-input)

Non-Core Packages

atom-beautify 0.29.18 
atom-css-clean 2.19.6 
atom-typescript 11.0.1 
busy-signal 1.3.0 
intentions 1.1.2 
linter 2.1.2 
linter-ui-default 1.2.2 
markdown-preview-plus 2.4.9
ghost commented 7 years ago

Identical problem here (except I have fewer non core packages)

Edit: I love this package so much! Really hoping for a fix

SeanJM commented 7 years ago

I know what the issue is. The next time I have free time, I’ll fix it.

Sean

On May 2, 2017, at 5:39 AM, Stian notifications@github.com wrote:

Identical problem here (except I have fewer non core packages)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SeanJM/atom-css-clean/issues/33#issuecomment-298579520, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUkyocM8yWe7eCP13yWasOGwQFqRnZJks5r1vnugaJpZM4NME1c.

ghost commented 7 years ago

Thank you Sean! This package is the main reason I use Atom. Again, thanks!

SeanJM commented 7 years ago

Me too. :)

On May 3, 2017, at 4:08 AM, Stian notifications@github.com wrote:

Thank you Sean! This package is the main reason I use Atom. Again, thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SeanJM/atom-css-clean/issues/33#issuecomment-298847335, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUkysYg1bmXq8d7e9Hb9qGf6Z3RrfUSks5r2DX8gaJpZM4NME1c.

SeanJM commented 7 years ago

Fixed