search

SeanMooney / arbiterd

Arbiterd - power and performance arbiter daemon
Apache License 2.0
0 stars 1 forks source link

Dockerfile update #29

Closed valleedelisle closed 2 years ago

valleedelisle commented 2 years ago

Updating Dockerfile with dumb-init and entrypoint

SeanMooney commented 2 years ago

i would prefer if we did not make any of the changes to the main docker file that are in this pr.

the way it works today is that you build the wheel using tox -e build then you do podman build Dockerfile.

we certenly should not be doing copy / /opt/arbiter we do not want the container to have the full git repo as that will make it much much bigger and include all the test data.

i intentially build it orginally using only the wheel to keep the container as small as possible which is why it does not have git and why the build tools are removed in the layer where they are added to ensure they are not included in the image.

valleedelisle commented 2 years ago

All right, I wasn't familiar with this. Let me explore that.