search

SeanNaren / deepspeech.pytorch

Speech Recognition using DeepSpeech2.
MIT License
2.1k stars 620 forks source link

Update: PL latest release #688

Closed krshrimali closed 2 years ago

krshrimali commented 2 years ago

Hi, @SeanNaren - Hope you're doing well. Lightning Ecosystem CI was failing with the following errors for a few attributes:

TypeError: __init__() got an unexpected keyword argument 'process_position'

These are some attributes that were removed in PL 1.7.0 release, post deprecation. This PR adds an alternative of each one of them, most of them as callbacks. prepare_data_per_node was shifted to LightningDataModule/LightningModule from Trainer in PL 1.7, so I've added it to the data configuration.

Note: post this PR, it's expected that the users will use latest PL release (>= 1.7.0) 🎉

cc: @SeanNaren (also cc-ing: @Borda @carmocca for visibility) :)

SeanNaren commented 2 years ago

What's up @krshrimali! great to hear from you man :)

this is awesome! do you mind just removing the 1.7.0 check and just forcing people to use 1.7.0 and above? Just need to update the requirements.txt as well!

krshrimali commented 2 years ago

What's up @krshrimali! great to hear from you man :)

Same here, Sean! 🎉

this is awesome! do you mind just removing the 1.7.0 check and just forcing people to use 1.7.0 and above? Just need to update the requirements.txt as well!

Done! Tested locally, works fine. Hope it looks good to you?

krshrimali commented 2 years ago

Update: also updated the PR description that PL 1.7.0+ will be supported after this PR.

SeanNaren commented 2 years ago

you guys are awesome as always, miss you all ❤️

krshrimali commented 2 years ago

you guys are awesome as always, miss you all heart

We all miss you as well, @SeanNaren! ❤️ It's a small world, we'll keep crossing paths 🔥