search

SeanNaren / warp-ctc

Pytorch Bindings for warp-ctc
Apache License 2.0
756 stars 271 forks source link

modification for pytorch 0.5.0 and adding blank option #72

Closed jinserk closed 6 years ago

jinserk commented 6 years ago

Hi, I'd like to send PR for updating for pytorch 0.5.0 and adding 'blank' option to point which index is blank label. Not sure the modification is rigorous or correct but it passed the tests/test_cpu.py and tests/test_gpu.py both.

Thanks, Jinserk

SeanNaren commented 6 years ago

Awesome thanks for this! I'll pull this in once the next version of PyTorch comes out that require these changes, till then I'll verify that this converges/works correctly based off the master branch.

jinserk commented 6 years ago

Well, actually the PyTorch v0.4.1 is already available from their official repo, but its torch.__version__ shows 0.5.0a0+35f7925, which means that we need to prepare the version at once. Previous warp-ctc couldn't be compiled with v0.4.1. :)

SeanNaren commented 6 years ago

Thanks so much for doing this @jinserk :)