search

SeanZ / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

gyp_msvs_version not set while running tests? #413

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
These use the value of GYP_MSVS_VERSION, but per discussion on 
https://codereview.chromium.org/195283002/, I don't think that gets set.

test/msvs/config_attrs/gyptest-config_attrs.py:20:if 
os.getenv('GYP_MSVS_VERSION'):
test/msvs/config_attrs/gyptest-config_attrs.py:21:  vc_version = 
['VC90','VC100'][int(os.getenv('GYP_MSVS_VERSION')) >= 2010]
test/msvs/external_builder/gyptest-all.py:17:if 
int(os.environ.get('GYP_MSVS_VERSION', 0)) < 2010:
test/win/gyptest-cl-analysis.py:17:    int(os.environ.get('GYP_MSVS_VERSION', 
0)) >= 2012):

Original issue reported on code.google.com by scottmg@chromium.org on 11 Mar 2014 at 6:42