search

SearchScale / dataimporthandler

Repository for DIH (Document Import Handler)
Apache License 2.0
68 stars 48 forks source link

Solr 9 #33

Closed kdebski85 closed 1 year ago

kdebski85 commented 2 years ago

Please first create rohitbemax:branch_9x branch, so I can change target branch.

kdebski85 commented 2 years ago

@epugh Could you please create rohitbemax:branch_9x branch, so I could change the target branch of this pull request? It should not be merged to branch_8x. Could you please review this PR?

chatman commented 2 years ago

Done, created branch_9x. Thanks for your PR, lets have it merged soon :-)

On Mon, Jun 20, 2022 at 1:02 PM kdebski85 @.***> wrote:

@epugh https://github.com/epugh Could you please create rohitbemax:branch_9x branch, so I could change the target branch of this pull request? It should not be merged to branch_8x. Could you please review this PR?

— Reply to this email directly, view it on GitHub https://github.com/rohitbemax/dataimporthandler/pull/33#issuecomment-1160079946, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDCR5HMWVYH2TNASGWU3YTVQANBVANCNFSM5Y2LZFEA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kdebski85 commented 2 years ago

Thanks! I changed the target branch to branch_9x

kdebski85 commented 2 years ago

Please review my changes

chatman commented 2 years ago

Apologies, I couldn't get to reviewing this due to some personal emergencies that took up my time. I shall review this this week. Thanks for your patience, @kdebski85 .

kdebski85 commented 2 years ago

@chatman In the meantime, I changed my job and I no longer use Solr (at least not directly). If you think any changes should be done to this PR, I could try to do them, but I will not be able to test on production-like data. Feel free to make changes to this PR.

abdullah-alfar commented 1 year ago

@kdebski85 @shalinmangar Hi , Please merge this request please please

abdullah-alfar commented 1 year ago

hi any update ?

kdebski85 commented 1 year ago

@aboodalfar Have you reviewed and tested these changes?

abdullah-alfar commented 1 year ago

@aboodalfar Have you reviewed and tested these changes?

no , I just need this update to support version 9

idurgakalyan commented 1 year ago

Hi, Any update on this?

chatman commented 1 year ago

Thank you for your patience and apologies for the delay. I shall get to this PR this week and attempt to release a 9x version of DIH. Thanks @kdebski85 @idurgakalyan !

idurgakalyan commented 1 year ago

Hi, Any update on testing and merging?

chatman commented 1 year ago

The project now has a new home and I just assumed ownership of the project under the SearchScale organization. https://lists.apache.org/thread/bmovqmy9gsg6fcfyl2oj6v2lft3x0jpq

I shall attempt to have a release done as soon as possible. Thank you all for the patience and understanding.

chatman commented 1 year ago

Thanks @kdebski85, I tested it with few records into a MariaDB table, and it worked flawlessly. Made a release for Solr 9.0.

However, when I compiled it with Solr 9.2, there were some compilation errors. I think we need another PR (branch_9x) and a release for Solr 9.2.

If you are interested in upgrading DIH to 9.2, I can invite you as a maintainer and share the release process with you.