search

SearchScale / dataimporthandler

Repository for DIH (Document Import Handler)
Apache License 2.0
68 stars 48 forks source link

fix #56 verification JSONPath for 9.3.0, 9.4.0 SOLR-17072 #57

Closed mkhludnev closed 1 year ago

mkhludnev commented 1 year ago

fixes the cause for https://issues.apache.org/jira/browse/SOLR-17072 impact is: false negative verification failure after successful package install.

chatman commented 1 year ago

Thank you Mikhail, it looks good. I'll merge, test and release by tonight.

On Mon, 13 Nov, 2023, 12:29 pm Mikhail Khludnev, @.***> wrote:

fixes the cause for https://issues.apache.org/jira/browse/SOLR-17072 impact is: false negative verification failure after successful package install.

You can view, comment on, or merge this pull request online at:

https://github.com/SearchScale/dataimporthandler/pull/57 Commit Summary

File Changes

(1 file https://github.com/SearchScale/dataimporthandler/pull/57/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/SearchScale/dataimporthandler/pull/57, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDCR5FYTIP35HU4YQ2G2ZDYEHAONAVCNFSM6AAAAAA7IVTDKOVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TAMBQGMZDQNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

epugh commented 1 year ago

We really need some BATS tests in Solr to verify our package management as things evolve and change!

epugh commented 1 year ago

and thanks @mkhludnev for digging in!

chatman commented 1 year ago

+1, Eric. I will add a sample package to solr-sandbox repo for use in BATS testing.

On Mon, 13 Nov, 2023, 8:48 pm Eric Pugh, @.***> wrote:

and thanks @mkhludnev https://github.com/mkhludnev for digging in!

— Reply to this email directly, view it on GitHub https://github.com/SearchScale/dataimporthandler/pull/57#issuecomment-1808361807, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDCR5GGIPAIZ3YFYPGIUK3YEI23HAVCNFSM6AAAAAA7IVTDKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGM3DCOBQG4 . You are receiving this because you commented.Message ID: @.***>

chatman commented 1 year ago

Thanks @mkhludnev. Seems like no new release is needed to make this work.