Closed mkhludnev closed 7 months ago
i think this is super fascinating ;-). I wonder if having a .bats test to show all the steps would be interesting? Like I did for https://github.com/apache/solr/pull/1999 ?? Also, if youi used a SolrCloudClient instead of Http2SolrClient, would that simplify some of the logic around slices and getting leaders?
Thanks, @epugh .
I couldn't find a sample of constructing CloudSolrClient
inside of Solr. It's used externally (not a surprise). Regarding bats, build scripts are far for maturity in this project.
So, here is another idea... Could you provide a demo.sh
script that walks people thorugh all the steps to use this? I think a small bit of the challenge is that this uses a number of both new AND cool features of Solr... I'd love to just do "demo.sh" and see all the stuff happening...
Thanks, @epugh . I couldn't find a sample of constructing
CloudSolrClient
inside of Solr. It's used externally (not a surprise). Regarding bats, build scripts are far for maturity in this project.
Also, CloudSolrClient
usage could totally be an optimization later.. What's key here is making DIH work better with Solr ;-).
@mkhludnev .
I'm thinking of merging this . Are tehre any loose ends that need to be tied up ?
oh. cool. At least I'd like to cover all methods with tests. I'll check it during next week.
@noblepaul , all
let's name it
as for now we have
/dataimport?command=full-import&writerImpl=SolrCloudWriter&destination-collection=data
SolrCloudWriter
(made by this PR)?destination-collection
. Kebab-naming or CamelCase? @noblepaul I'm done with the code. I'm open for suggestions regarding naming.
@noblepaul if you don't like using SolrCmdDistributor
I can add SolrCloudSyncWriter
which sends docs one-by one using SolrClient
. Although I'm not sure how to pick a leader node.
we use camel case everywhere. For instance ,
destinationCollection
instead of destination-collection
destinationCollection
done
Thanks Michael
Oh cool. Thanks Noble. Looking forward to release.
yeahh// it's just a clickbait.
I just get known about stateless coordinator node and decided that it might be useful for DIH.
TLDR;
introduce
SolrCloudWriter
withdestination-collection
parameter.Context
Can't migrate out of DIH, attempting to run it in cloud (zk distributed Solr).
Problem
DIH runs in one or the replicas overload it and make cluster unstable.
Suggestion
.sys.COORDINATOR-COLL-configset-A
collection.I'm leaving it as draft PR, until someone share some thoughts about it.