search

SeargeDP / SeargeSDXL

Custom nodes and workflows for SDXL in ComfyUI
https://civitai.com/models/111463
MIT License
780 stars 59 forks source link

New ComfUI Update broke your Node. #142

Open Piscabo opened 6 months ago

Piscabo commented 6 months ago

Is there a fix on the way? ComfyUI Revision: 2115 [0a030098] | Released on '2024-04-06'

Searge-SDXL v4.3.1 in H:\ComfyUI\custom_nodes\SeargeSDXL Traceback (most recent call last): File "H:\ComfyUI\nodes.py", line 1889, in load_custom_node module_spec.loader.exec_module(module) File "", line 940, in exec_module File "", line 241, in _call_with_frames_removed File "H:\ComfyUI\custom_nodes\SeargeSDXL__init__.py", line 35, in from .searge_sdxl import SEARGE_CLASS_MAPPINGS, SEARGE_DISPLAY_NAME_MAPPINGS File "H:\ComfyUI\custom_nodes\SeargeSDXL\searge_sdxl.py", line 54, in from .modules.magic_box import SeargeMagicBox File "H:\ComfyUI\custom_nodes\SeargeSDXL\modules\magic_box.py", line 38, in from .stage_latent_detailer import SeargeStageLatentDetailer File "H:\ComfyUI\custom_nodes\SeargeSDXL\modules\stage_latent_detailer.py", line 29, in from comfy.sample import prepare_mask ImportError: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\comfy\sample.py)

Cannot import H:\ComfyUI\custom_nodes\SeargeSDXL module for custom nodes: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\comfy\sample.py)

"1.3 seconds (IMPORT FAILED): H:\ComfyUI\custom_nodes\SeargeSDXL"

hashmil commented 6 months ago

i'm having the same issue! 

Searge-SDXL v4.3.1 in /Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL
Traceback (most recent call last):
  File "/Users/hash.milhan/ComfyUI/nodes.py", line 1864, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/__init__.py", line 35, in <module>
    from .searge_sdxl import SEARGE_CLASS_MAPPINGS, SEARGE_DISPLAY_NAME_MAPPINGS
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/searge_sdxl.py", line 54, in <module>
    from .modules.magic_box import SeargeMagicBox
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/modules/magic_box.py", line 38, in <module>
    from .stage_latent_detailer import SeargeStageLatentDetailer
  File "/Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL/modules/stage_latent_detailer.py", line 29, in <module>
    from comfy.sample import prepare_mask
ImportError: cannot import name 'prepare_mask' from 'comfy.sample' (/Users/hash.milhan/ComfyUI/comfy/sample.py)

Cannot import /Users/hash.milhan/ComfyUI/custom_nodes/SeargeSDXL module for custom nodes: cannot import name 'prepare_mask' from 'comfy.sample' (/Users/hash.milhan/ComfyUI/comfy/sample.py)

Edit - this seems to have fixed it in the short term: https://github.com/SeargeDP/SeargeSDXL/issues/137#issuecomment-2040522926

huwhitememes commented 6 months ago

This is what happened to me also 😢

oktetopython commented 6 months ago

Traceback (most recent call last): File "H:\ComfyUI\ComfyUI\nodes.py", line 1864, in load_custom_node module_spec.loader.exec_module(module) File "", line 940, in exec_module File "", line 241, in _call_with_frames_removed File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL__init__.py", line 35, in from .searge_sdxl import SEARGE_CLASS_MAPPINGS, SEARGE_DISPLAY_NAME_MAPPINGS File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL\searge_sdxl.py", line 54, in from .modules.magic_box import SeargeMagicBox File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL\modules\magic_box.py", line 38, in from .stage_latent_detailer import SeargeStageLatentDetailer File "H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL\modules\stage_latent_detailer.py", line 29, in from comfy.sample import prepare_mask ImportError: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\ComfyUI\comfy\sample.py)

Cannot import H:\ComfyUI\ComfyUI\custom_nodes\SeargeSDXL module for custom nodes: cannot import name 'prepare_mask' from 'comfy.sample' (H:\ComfyUI\ComfyUI\comfy\sample.py)

hashmil commented 6 months ago

this PR is supposed to fix it - https://github.com/SeargeDP/SeargeSDXL/pull/140

stephantual commented 6 months ago

Confirmed and reconfirmed :). Thanks for the PR, hopefully it gets pushed in soon.

0xcyph commented 6 months ago

any updates? : ) cant use any LCM rn : (

stephantual commented 5 months ago

it's fixed now, thank you