consider all elements and exclude text nodes

SeaseLtd / ltr-tools

Set of command line tools for Learning To Rank

Apache License 2.0

14 stars 4 forks source link

consider all elements and exclude text nodes #1

Open stefan-langenmaier opened 7 years ago

stefan-langenmaier commented 7 years ago

I'm not sure if this is the best approach but, in my json model file the weights were sorted after the trees and so I got NPE when importing.

alessandrobenedetti commented 6 years ago

hi @stefan-langenmaier , sorry for the very late reply but I missed this one ! I would be happy to merge the change, but can you provide a unit-test in your Pull Request ?

You can :

provide a sample model that is failing for you ( adding it to /ltr-tools/src/test/resources/models/)
add a test similar to indexModel_sampleModel_shouldIndexAllModelSplits
verify the other tests are not broken

Then we can discuss it and merge it !

Cheers

stefan-langenmaier commented 6 years ago

Hello @alessandrobenedetti

no worries. :) I'll try to work on it next week.

Cheers