search

SeasideSt / Parasol

Testing web apps in Smalltalk using Selenium WebDriver.
MIT License
31 stars 16 forks source link

waitUntil on BPSeasideWebDriverTestCase #13

Open LesageYann opened 6 years ago

LesageYann commented 6 years ago

Hi,

I have see two interesting functions : BPSeasideWebDriverTestCase >> waitUntil:checkEvery:timeoutAfter: BPSeasideWebDriverTestCase >> waitUntil:checkEvery:timeoutAfter:with:

Why don't move this on parent BPSeasideWebDriverTestCase ?

Rinzwind commented 6 years ago

You mean the waitUntil:* methods in BPParasolSelfTestCase? It does look like those could be pulled up to BPSeasideWebDriverTestCase or BPWebDriverTestCase.

Though we should instead, perhaps, implement the “waiting” framework that the Java reference implementation has. The WebDriver website has a small example that demonstrates the basics (it makes use of WebDriver.until and ExpectedConditions.presenceOfElementLocated; neither class currently has a counterpart in Parasol).