search

SeasideSt / Parasol

Testing web apps in Smalltalk using Selenium WebDriver.
MIT License
31 stars 16 forks source link

Test BPRemoteWebDriverTestCase>>#testCookies fails in Squeak #32

Open Rinzwind opened 5 years ago

Rinzwind commented 5 years ago

The test BPRemoteWebDriverTestCase>>#testCookies fails in Squeak:

https://travis-ci.org/SeasideSt/Parasol/jobs/550887953#L1139

Rinzwind commented 5 years ago

This is due to an error in generating a response; WAWebServerAdaptor>>#responseFrom: sends #oldNetscapeString to a WACookie, which is not implemented:

500 Internal Server Error 2019-06-26 20-23-51

Rinzwind commented 5 years ago

Related to: https://github.com/SeasideSt/Seaside/commit/a9b5b3532204e7d042da10c4bf1e0030ae679555#diff-9f7d0e1bf4044ba665796ec6d551dcbc

For now, I simply marked the test as an expected failure on Squeak (https://github.com/SeasideSt/Parasol/commit/953555d38c6dcc00e6bd79913f5831d609b7e2a9).

Rinzwind commented 5 years ago

Instead of marking the test as an expected failure, I included a post-loading script to add an implementation of WACookie>>#oldNetscapeString (https://github.com/SeasideSt/Parasol/commit/e024e6f3fb8095cac2cf9f355bf683fbf2fc9c22).

jbrichau commented 5 years ago

@Rinzwind That looks more like a bug in Seaside to me, because older Pharo versions have older Zinc loaded. I quickly added the issue so we can fix it there (https://github.com/SeasideSt/Seaside/issues/1141)

timrowledge commented 8 months ago

Forgive me if this seems a stupid question - I just hit this bug in my testing of seaside 3.5.4 in Squeak 6.1 trunk. It's not at all clear to me from looking at the issues here what the 'proper' fix is. It works as best I can tell with a simple substitution of rfc6265String for oldNetscapeString in WAWebServerAdaptor>>#responseFrom:. The relevant package seems to be WebClient-Seaside-Adaptor. WAWebServerAdaptor.txt