search

SeasideSt / Parasol

Testing web apps in Smalltalk using Selenium WebDriver.
MIT License
31 stars 16 forks source link

This commit adds three functions to BPWindow descripted in Serenity: … #61

Closed colorow closed 1 year ago

colorow commented 1 year ago

…fullscreen, maximize, and minimize. I also wrote a test for these, but I could not fully load Seaside, and the tests need Seaside to run, so I did not include the tests. Let me know if a test is required for this to be merged.

jbrichau commented 1 year ago

Hi @colorow Thanks for this addition. I do not see the tests for it, so maybe you forgot to commit them? I also notice the PR also removes the BPTestComponentOptions class, which I think is not the intention? Can you fix that?

colorow commented 1 year ago

Is it ok to resubmit this without a test? I am trying to write a project with Parasol but without Seaside. This seems to be leading to a problem with writing a test for it, because the TestCase tests do have references to Seaside objects. When I load Seaside3, I can't load Parasol-Tests, it will give me an error:

"Method protocol 'rendering' for the method 'renderContentOn:' in class 'BPTestComponentOptions' is inconsistent with the package name '*parasol-tests'".

This seems to be what deleted BPTestComponentOptions, I didn't do that deliberately.

The cleanest thing I can do is start over and just create a pull request for the code change. I did test it in my browser.