search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Remove Swazoo project from 3.6 (#1222); complete the fix for Parasol/Seaside infinite loop (SeasideSt/Parasol#43) #1228

Closed dalehenrich closed 4 years ago

dalehenrich commented 4 years ago

fix for #1222 .

Once this PR is merged, the GemStone SeasideSt/Parasol travis tests should start passing ... baseline modifications were needed to ensure that Parasol-Seaside package was loaded AFTER Seaside-Tools-Core (where WAAdmin is loaded)

dalehenrich commented 4 years ago

@jbrichau, Squeak-5.2 seems to be the only case failing the builds and that has been true for some time now ...

dalehenrich commented 4 years ago

@jbrichau ... the 3.6.0 release is on a fast track ... I've got two tests that I can work on without this merge, but the next phase of work involves running internal tests against the master branch of Seaside and while I can fiddle things to use this branch, it is much simpler for me to be able to use the master branch ... if you need more time to review, I understand and can wait a couple more days, but then I'll need to decide whether I need to start making changes to the internal tests so I can have time to fix any problems that might show up without delaying the release (I think we're targeting something like 2 weeks out), so the sooner I know about problems the sooner I can go about fixing them:)

I know that I can press the merge button, but requiring that Parasol has to be loaded from Seaside and not the other away around for GemStone could be a problem and I don't want to force this change on you if you don't approve ... again, knowin gsooner rather than later would be a good thing at this stage ...

dalehenrich commented 4 years ago

THANKS, @jbrichau!