search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

GemStone 3.6 port complete #1230

Closed dalehenrich closed 4 years ago

dalehenrich commented 4 years ago

fix #1226 and move Squeak-5.2 to allowed failures (#1229).

While the 3.6.0 port did not require any direct changes to the Seaside code itself, a number of other projects were changed in order to get all of the Seaside tests to pass for 3.5.4 and 3.6.0.

@jbrichau, no review required as the changes do not involve the Seaside code base ... other than adding #projectClass to the baseline, to complete the contract for metadataless operation ...

There was a bug in Metacello/metacello#531 that reared it's head when I added the #projectClass method and that may have been the reason it was not done when the other changes were made, but that bug is fixed.

dalehenrich commented 4 years ago

Oddly enough no travis builds were triggered by this PR ... I'm pretty sure this should run clean, so I'm boint to go ahead and merge ...

dalehenrich commented 4 years ago

Hmmm, I ended up manually triggering a travis build on the master branch after the merge, because an automatic merge didn't run either ... pretty weird behavior... the network view is also not completing for me either (maybe it's my firefox misbehaving?) ... at least I was able to get a build run on this master branch ...

dalehenrich commented 4 years ago

Haha, the build for the merge just got triggered, so it seems that travis and/or github have a healthy delay somewhere in the system ... well the build I triggered ran clean so we're good to go...