search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Control panel broken in Pharo 11 due to Spec2 change #1345

Closed astares closed 1 year ago

astares commented 2 years ago

image

Easy but bad workaround: change #asToolbarPresenter into #asMenuBarPresenter

will give you:

image

astares commented 2 years ago

Correct way to fix this is to have the missing method implemented in Spec2:

asToolbarPresenter
    ^ SpToolbarPresenterBuilder new
        visit: self;
        toolbarPresenter
astares commented 2 years ago

image

astares commented 2 years ago

Opened an issue for Spec2: https://github.com/pharo-spec/Spec/issues/1316

svenvc commented 1 year ago

Correct way to fix this is to have the missing method implemented in Spec2:

asToolbarPresenter
  ^ SpToolbarPresenterBuilder new
      visit: self;
      toolbarPresenter

I can confirm that this works fine !

I implemented it inline, not adding the asToolbarPresenter method.