SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Some fixes #1361

Closed jbrichau closed 1 year ago

jbrichau commented 1 year ago

Fixes #1326, #1360, #1359

Also disables the CORS functional webtest since it started failing in the github builds only...

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.08 :warning:

Comparison is base (1f56b5d) 54.20% compared to head (5e7a990) 54.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1361 +/- ## ========================================== - Coverage 54.20% 54.13% -0.08% ========================================== Files 8870 8870 Lines 72019 72018 -1 ========================================== - Hits 39041 38989 -52 - Misses 32978 33029 +51 ``` | [Impacted Files](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | Coverage Δ | | |---|---|---| | [...e.package/JSJsonParser.class/class/isDeprecated.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUpTT04tQ29yZS5wYWNrYWdlL0pTSnNvblBhcnNlci5jbGFzcy9jbGFzcy9pc0RlcHJlY2F0ZWQuc3Q=) | `0.00% <0.00%> (ø)` | | | [...ackage/WAWelcomeFiles.class/instance/welcomeCss.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVdlbGNvbWUucGFja2FnZS9XQVdlbGNvbWVGaWxlcy5jbGFzcy9pbnN0YW5jZS93ZWxjb21lQ3NzLnN0) | `0.00% <0.00%> (ø)` | | | [...ctionalTestCase.class/instance/expectedFailures.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVRlc3RzLVBhcmFzb2wucGFja2FnZS9XQVdlYkRyaXZlckZ1bmN0aW9uYWxUZXN0Q2FzZS5jbGFzcy9pbnN0YW5jZS9leHBlY3RlZEZhaWx1cmVzLnN0) | `100.00% <100.00%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.