SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
516 stars 71 forks source link

JQAutocomplete (follow-up to issue #1232): content-type for json call… #1364

Closed jbrichau closed 1 year ago

jbrichau commented 1 year ago

…back in jQueryUI autocompleter should be application/json and not text/plain. Reworked the callback implementation to no longer create intermediate objects for serialization to json but use the json canvas directly.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (9866f65) 54.13% compared to head (3d53ed6) 54.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1364 +/- ## ========================================== - Coverage 54.13% 54.11% -0.03% ========================================== Files 8870 8871 +1 Lines 72018 72049 +31 ========================================== Hits 38989 38989 - Misses 33029 33060 +31 ``` | [Impacted Files](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | Coverage Δ | | |---|---|---| | [...eFunctionalTest.class/instance/renderContentOn..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9KUXVlcnktVGVzdHMtVUkucGFja2FnZS9KUUF1dG9jb21wbGV0ZUZ1bmN0aW9uYWxUZXN0LmNsYXNzL2luc3RhbmNlL3JlbmRlckNvbnRlbnRPbi4uc3Q=) | `0.00% <0.00%> (ø)` | | | [...est.class/instance/renderSelectedPackageNameOn..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9KUXVlcnktVGVzdHMtVUkucGFja2FnZS9KUUF1dG9jb21wbGV0ZUZ1bmN0aW9uYWxUZXN0LmNsYXNzL2luc3RhbmNlL3JlbmRlclNlbGVjdGVkUGFja2FnZU5hbWVPbi4uc3Q=) | `0.00% <0.00%> (ø)` | | | [.../JQAutocomplete.class/instance/search.callback..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9KUXVlcnktVUkucGFja2FnZS9KUUF1dG9jb21wbGV0ZS5jbGFzcy9pbnN0YW5jZS9zZWFyY2guY2FsbGJhY2suLnN0) | `0.00% <0.00%> (ø)` | | | [...complete.class/instance/search.labels.callback..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9KUXVlcnktVUkucGFja2FnZS9KUUF1dG9jb21wbGV0ZS5jbGFzcy9pbnN0YW5jZS9zZWFyY2gubGFiZWxzLmNhbGxiYWNrLi5zdA==) | `0.00% <0.00%> (ø)` | | | [...e/JQAutocomplete.class/instance/sourceCallback..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9KUXVlcnktVUkucGFja2FnZS9KUUF1dG9jb21wbGV0ZS5jbGFzcy9pbnN0YW5jZS9zb3VyY2VDYWxsYmFjay4uc3Q=) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.