Closed jbrichau closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.03
:tada:
Comparison is base (
2037d0c
) 54.11% compared to head (2f6e405
) 54.14%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
JSON object keys must be strings. The Seaside JSON writer did not respect this. This PR now allows to only convert dictionaries with String keys, when a flag is set. Otherwise an error is thrown. The idea is to remove the flag in the next major version of Seaside, but already introduce the behavior now so people have a migration path.
Fixes #1367
Also added test to show the WAJsonParser did not accept numbers as keys (which is correct, but inconsistent with the JSON writer).
Also removed the
Pharo70-JSON
package with an extension forOrderedDictionary
and moved it toPharo-JSON
. I noticed this because of failing test for Pharo 7. Since OrderedDictionary is part of Pharo since Pharo 7 and we dropped Pharo 6 and earlier some time ago, this can now reside in the Pharo-JSON package.FInally, refactored tests for JSON to remove the override of
assert:equals:
and replaced it withassert:gives: