search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Fix for issue #1369 (improvements for WAGettextExporter) #1370

Closed jbrichau closed 1 year ago

jbrichau commented 1 year ago

Tackles issues mentioned in https://github.com/SeasideSt/Seaside/issues/1369

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 94.03% and no project coverage change.

Comparison is base (ec8c4a2) 54.14% compared to head (b642301) 54.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1370 +/- ## ======================================= Coverage 54.14% 54.15% ======================================= Files 8876 8883 +7 Lines 72097 72141 +44 ======================================= + Hits 39037 39067 +30 - Misses 33060 33074 +14 ``` | [Impacted Files](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | Coverage Δ | | |---|---|---| | [...etTextExporter.class/class/newForRBEnvironment..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2NsYXNzL25ld0ZvclJCRW52aXJvbm1lbnQuLnN0) | `0.00% <0.00%> (ø)` | | | [...mentsFinder.class/instance/translatedArguments..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBVHJhbnNsYXRlZEFyZ3VtZW50c0ZpbmRlci5jbGFzcy9pbnN0YW5jZS90cmFuc2xhdGVkQXJndW1lbnRzLi5zdA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...tExporter.class/instance/createAndSortTriplets..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2NyZWF0ZUFuZFNvcnRUcmlwbGV0cy4uc3Q=) | `100.00% <100.00%> (ø)` | | | [.../WAGetTextExporter.class/instance/createHeaders.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2NyZWF0ZUhlYWRlcnMuc3Q=) | `100.00% <100.00%> (ø)` | | | [...class/instance/createStringMethodRefDictionary..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2NyZWF0ZVN0cmluZ01ldGhvZFJlZkRpY3Rpb25hcnkuLnN0) | `100.00% <100.00%> (ø)` | | | [...tTextExporter.class/instance/currentDateAndTime.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2N1cnJlbnREYXRlQW5kVGltZS5zdA==) | `100.00% <100.00%> (ø)` | | | [.../WAGetTextExporter.class/instance/exportCatalog.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2V4cG9ydENhdGFsb2cuc3Q=) | `100.00% <100.00%> (ø)` | | | [...e/WAGetTextExporter.class/instance/exportHeader.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2V4cG9ydEhlYWRlci5zdA==) | `100.00% <100.00%> (ø)` | | | [...orter.class/instance/exportHeaderLineKey.value..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2V4cG9ydEhlYWRlckxpbmVLZXkudmFsdWUuLnN0) | `100.00% <100.00%> (ø)` | | | [.../WAGetTextExporter.class/instance/formatString..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVBoYXJvLUdldHRleHQtQ29yZS5wYWNrYWdlL1dBR2V0VGV4dEV4cG9ydGVyLmNsYXNzL2luc3RhbmNlL2Zvcm1hdFN0cmluZy4uc3Q=) | `100.00% <100.00%> (ø)` | | | ... and [10 more](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1370/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.