codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and project coverage change: +0.02% :tada:
Comparison is base (
7d0ccbd) 54.17% compared to head (da095f6) 54.19%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1377 +/- ## ========================================== + Coverage 54.17% 54.19% +0.02% ========================================== Files 8887 8887 Lines 72215 72220 +5 ========================================== + Hits 39121 39139 +18 + Misses 33094 33081 -13 ``` | [Files Changed](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | Coverage Δ | | |---|---|---| | [...kage/WAUrl.class/instance/initializeFromString..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUNvcmUucGFja2FnZS9XQVVybC5jbGFzcy9pbnN0YW5jZS9pbml0aWFsaXplRnJvbVN0cmluZy4uc3Q=) | `100.00% <100.00%> (ø)` | | | [...rlTest.class/instance/testNastyEdgeCasesParsing.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLVRlc3RzLUNvcmUucGFja2FnZS9XQVVybFRlc3QuY2xhc3MvaW5zdGFuY2UvdGVzdE5hc3R5RWRnZUNhc2VzUGFyc2luZy5zdA==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1377/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request fixes issue #1376 by making
#initializeFromString:in WAUrl take into account that://can also be included in the query.The example this pull request adds to
#testNastyEdgeCasesParsingreflects the use of#absolute:in#requestUrlFor:in WAFastCGIRequestConverter: the argument to#absolute:is not a valid absolute URI as defined in section 4.3 in RFC 3986, as it does not begin with a scheme, but it is a valid request target as defined in section 3.2 in RFC 9112. WAUrl and WAFastCGIRequestConverter should maybe be made to better distinguish between those.