search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

fix: Add PackageManifest stub class #1384

Closed theseion closed 1 year ago

theseion commented 1 year ago

Add PackageManifest to prevent warnings when loading Pharo package manifest subclasses.

Fixes #1382

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff85383) 48.67% compared to head (7ca379a) 48.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1384 +/- ## ======================================= Coverage 48.67% 48.67% ======================================= Files 8948 8948 Lines 80512 80512 ======================================= Hits 39192 39192 Misses 41320 41320 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jbrichau commented 1 year ago

@theseion The package should also be added to the metacello baseline for Squeak

theseion commented 1 year ago

It's already there, isn't it?

baselinesqueak: spec

    "Mind that baselinepharo still has a squeakcommon section!"
    spec
        for: #squeak
        do: [ 
            spec
                package: 'Seaside-Squeak-Compatibility';
        "..."
jbrichau commented 1 year ago

@theseion Ow. I misread this as a new package but indeed. It already is there.