search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Use #greaseAsByteArray when computing etag #1385

Closed theseion closed 1 year ago

theseion commented 1 year ago

Fixes #1383

theseion commented 1 year ago

This PR depends on https://github.com/SeasideSt/Grease/pull/161.

jbrichau commented 1 year ago

As soon as the mentioned PR is merged and we also get the GsDevKit/Grease mirror synced (necessary for GemStone builds), we can merge this one.

jbrichau commented 1 year ago

Created the PR to also update Grease in GsDevkit/GLASS: https://github.com/GsDevKit/Grease/pull/28

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff85383) 48.67% compared to head (995a20b) 48.67%. Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1385 +/- ## ======================================= Coverage 48.67% 48.67% ======================================= Files 8948 8948 Lines 80512 80512 ======================================= Hits 39192 39192 Misses 41320 41320 ``` | [Files](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | Coverage Ξ” | | |---|---|---| | [...bstractFileLibrary.class/instance/entityTagFor..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUNvcmUucGFja2FnZS9XQUFic3RyYWN0RmlsZUxpYnJhcnkuY2xhc3MvaW5zdGFuY2UvZW50aXR5VGFnRm9yLi5zdA==) | `100.00% <100.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

theseion commented 1 year ago

Pharo-12: a new deprecation that heavily impacts Monticello causes timeouts. Others: unrelated test failures.

timrowledge commented 1 year ago

Just to catch up a little, Squeak 6.1 now has #asByteArray for LargePositiveIntegers. Prior versions would simply need to use sometihng akin to

^theBigNumber as: ByteArray

theseion commented 1 year ago

Thanks. I'm surprised you got it in after the discussions I saw on the mailing list πŸ˜‰.

timrowledge commented 1 year ago

On 2023-11-05, at 6:20 AM, Max Leske @.***> wrote:

Thanks. I'm surprised you got it in after the discussions I saw on the mailing list πŸ˜‰.

Oh, the privileges of being a 25+ year core developer and all that. It's a good point though that asByteArray is a pretty bad message, what with all the potential meanings. Should be using more specific names properly appropriate to the usage and in many case, not going that route at all. For example, applied to a bitmap in order to make the compression work... just daft.

tim

tim Rowledge; @.***; http://www.rowledge.org/tim Sarchasm (n): The gulf between the author of sarcastic wit and the person who doesn't get it.