codecov[bot]
commented
11 months ago Codecov Report
Attention: 54 lines in your changes are missing coverage. Please review.
Comparison is base (
80af760) 48.67% compared to head (accfd4b) 48.64%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1388 +/- ## ========================================== - Coverage 48.67% 48.64% -0.04% ========================================== Files 8948 8954 +6 Lines 80512 80572 +60 ========================================== Hits 39192 39192 - Misses 41320 41380 +60 ``` | [Files](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | Coverage Δ | | |---|---|---| | [...ssingActionContinuation.class/instance/continue.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0NhbGxiYWNrUHJvY2Vzc2luZ0FjdGlvbkNvbnRpbnVhdGlvbi5jbGFzcy9pbnN0YW5jZS9jb250aW51ZS5zdA==) | `0.00% <ø> (ø)` | | | [...on.class/instance/createTurboRenderContinuation.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0NhbGxiYWNrUHJvY2Vzc2luZ0FjdGlvbkNvbnRpbnVhdGlvbi5jbGFzcy9pbnN0YW5jZS9jcmVhdGVUdXJib1JlbmRlckNvbnRpbnVhdGlvbi5zdA==) | `0.00% <ø> (ø)` | | | [...urboFileLibrary.class/instance/turboes2017esmJs.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZpbGVMaWJyYXJ5LmNsYXNzL2luc3RhbmNlL3R1cmJvZXMyMDE3ZXNtSnMuc3Q=) | `0.00% <ø> (ø)` | | | [...urboFileLibrary.class/instance/turboes2017umdJs.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZpbGVMaWJyYXJ5LmNsYXNzL2luc3RhbmNlL3R1cmJvZXMyMDE3dW1kSnMuc3Q=) | `0.00% <ø> (ø)` | | | [...Turbo-Core.package/WATurboFrame.class/class/new.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZyYW1lLmNsYXNzL2NsYXNzL25ldy5zdA==) | `0.00% <ø> (ø)` | | | [...ore.package/WATurboFrame.class/class/newWithId..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZyYW1lLmNsYXNzL2NsYXNzL25ld1dpdGhJZC4uc3Q=) | `0.00% <ø> (ø)` | | | [...rbo-Core.package/WATurboFrame.class/instance/id.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZyYW1lLmNsYXNzL2luc3RhbmNlL2lkLnN0) | `0.00% <ø> (ø)` | | | [...e/WATurboFrame.class/instance/initializeWithId..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZyYW1lLmNsYXNzL2luc3RhbmNlL2luaXRpYWxpemVXaXRoSWQuLnN0) | `0.00% <ø> (ø)` | | | [...ackage/WATurboFrame.class/instance/isTurboFrame.st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZyYW1lLmNsYXNzL2luc3RhbmNlL2lzVHVyYm9GcmFtZS5zdA==) | `0.00% <ø> (ø)` | | | [...ge/WATurboFrame.class/instance/renderContentOn..st](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt#diff-cmVwb3NpdG9yeS9TZWFzaWRlLUhvdHdpcmVUdXJiby1Db3JlLnBhY2thZ2UvV0FUdXJib0ZyYW1lLmNsYXNzL2luc3RhbmNlL3JlbmRlckNvbnRlbnRPbi4uc3Q=) | `0.00% <ø> (ø)` | | | ... and [46 more](https://app.codecov.io/gh/SeasideSt/Seaside/pull/1388?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SeasideSt) | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The older version of Metacello being used in extent0.seaside.dbf was not properly dealing with the fact that the required packages for the newish HotwireTurbo packages were not complete and resulted in undefined globals. Adjusting the required packages for the HotwireTurbo packages fixed the package load order issue and reqolved the undefined global references.
Another point is that the Seaside-HotwireTurbo and Seaside-HotwireTurbo-Examples share a common base name for the package which is in violation of the Monticello package naming conventionsand would lead to unwanted package mangling if the HotwireTurbo were modified and saved from an image that follows the Monticello package naming convention. So I renamed Seaside-HotwireTurbo to Seaside-HotwireTurbo-Core to avoid this potential issue.