Squeak needs variant implementation of #openDebuggerOn:

timrowledge commented 1 year ago

The vanilla Process>>#debug:title:full: is deprecated in Squeak 6.1.

I propose implementing GRSqueakPlatform>>#openDebuggerOn: openDebuggerOn: anError "Squeak variant based on the Pharo platform code, intended to avoid the deprecated #debug:title:full: message"

| process |
process := Processor activeProcess.
"If we are running in the UI process, we don't want to suspend the active process. The
error was presumably triggered while stepping in the Debugger. If we simply immediately
signal an UnhandledError, the debugger will catch this and display the signaling context.
It isn't perfect or pretty but it works."
process == Project uiProcess
    ifTrue: [UnhandledError signalForException: anError ]
    ifFalse: 
        [WorldState addDeferredUIMessage:
            [ToolSet handleError: anError].
        process suspend]

timrowledge commented 1 year ago

Better, simpler, more resilient version - Grease-Squeak-debugger.2.txt

marschall commented 4 months ago

Thanks, will be resolved in https://github.com/SeasideSt/Grease/pull/181.

timrowledge commented 4 months ago

Many thanks for taking the time to do this.

On 2024-07-16, at 12:29 PM, Philippe Marschall @.***> wrote:

Thanks, will be resolved in SeasideSt/Grease#181.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

tim

tim Rowledge; @.***; http://www.rowledge.org/tim Earth is 98% full...please delete anyone you can.

SeasideSt / Seaside

Squeak needs variant implementation of #openDebuggerOn: #1390

tim