search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
508 stars 71 forks source link

Slime renovation #1398

Closed jbrichau closed 5 months ago

jbrichau commented 6 months ago

Ported the Seaside Slime rules to the Renraku code critiques framework. Removed obsolete rules (i.e. those with transforms for porting from Seaside 2.8)

codecov[bot] commented 6 months ago

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (cb9f147) 48.75% compared to head (8192f79) 48.34%.

Files Patch % Lines
...kage/WASlime.class/class/findAttributeSelectors.st 0.00% 25 Missing :warning:
...elopment.class/class/enableSeasideCodeCritiques.st 0.00% 16 Missing :warning:
...package/WASlime.class/class/isCallbackSelector..st 0.00% 7 Missing :warning:
...allSuperImplementationRule.class/instance/group.st 0.00% 4 Missing :warning:
...gesStateWhileRenderingRule.class/instance/group.st 0.00% 4 Missing :warning:
...age/WACookieConversionRule.class/instance/group.st 0.00% 4 Missing :warning:
...ltiplePrimaryAjaxCallbacks.class/instance/group.st 0.00% 4 Missing :warning:
...DoNotUseWhileRenderingRule.class/instance/group.st 0.00% 4 Missing :warning:
...DoNotUseWithinCallbackRule.class/instance/group.st 0.00% 4 Missing :warning:
...ctCallbackCodeToMethodRule.class/instance/group.st 0.00% 4 Missing :warning:
... and 10 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1398 +/- ## ========================================== - Coverage 48.75% 48.34% -0.41% ========================================== Files 9071 9157 +86 Lines 81579 82113 +534 ========================================== - Hits 39771 39701 -70 - Misses 41808 42412 +604 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.