search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Fix CORS test on github actions #1400

Closed jbrichau closed 9 months ago

jbrichau commented 9 months ago

After searching for over a day to debug and understand... it turns out changing the port from 8084 to 8888 was what was needed to make this work on Github CI....

codecov[bot] commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e440868) 48.35% compared to head (24d01c4) 48.42%.

:exclamation: Current head 24d01c4 differs from pull request most recent head 5cd2159. Consider uploading reports for the commit 5cd2159 to get more accurate results

Files Patch % Lines
...rFunctionalTestCase.class/instance/clickRestart.st 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1400 +/- ## ========================================== + Coverage 48.35% 48.42% +0.06% ========================================== Files 9159 9161 +2 Lines 82123 82141 +18 ========================================== + Hits 39711 39774 +63 + Misses 42412 42367 -45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.