SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Cleanup old methods #1435

Closed jbrichau closed 4 months ago

jbrichau commented 4 months ago
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 1.97628% with 248 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (cb4b8ef) to head (fde0005).

Files Patch % Lines
...deRemainingBecausePharo8LimitationOfLiteralsTo..st 0.00% 132 Missing :warning:
...nalTest.class/instance/countriesPerCurrencyCode.st 0.00% 66 Missing :warning:
...alTest.class/instance/currenciesAndCountriesOn..st 0.00% 10 Missing :warning:
...eFunctionalTest.class/instance/countryNamesFor..st 0.00% 8 Missing :warning:
...eFunctionalTest.class/instance/renderContentOn..st 0.00% 8 Missing :warning:
...est.class/instance/renderSelectedCountryNameOn..st 0.00% 6 Missing :warning:
...unctionalTest.class/instance/listOfCountryNames.st 0.00% 4 Missing :warning:
...alTest.class/instance/countriesForCurrencyCode..st 0.00% 4 Missing :warning:
...nctionalTest.class/instance/listOfCurrencyCodes.st 0.00% 4 Missing :warning:
...pleteFunctionalTest.class/instance/countryNames.st 0.00% 4 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1435 +/- ## ========================================== + Coverage 49.04% 49.33% +0.29% ========================================== Files 9143 9073 -70 Lines 80555 80055 -500 ========================================== - Hits 39506 39498 -8 + Misses 41049 40557 -492 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marschall commented 4 months ago

Maybe I'm missing something here. Unfortunately we still have some senders of GRPackage class >> #grPackages

jbrichau commented 4 months ago

Yes, that was not so good... just did not check those.