search

SeasideSt / Seaside

The framework for developing sophisticated web applications in Smalltalk.
MIT License
519 stars 71 forks source link

Add test related to Grease issue 33. #1442

Closed kurtkilpela closed 3 months ago

kurtkilpela commented 3 months ago

FastCGI uses GRUtf8CodecStream instances. A missing selector was not detected by other test cases which use WriteStream instances.

See: https://github.com/GsDevKit/Grease/issues/33

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.42%. Comparing base (1523181) to head (4bd1087). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1442 +/- ## ========================================== + Coverage 49.39% 49.42% +0.02% ========================================== Files 9078 9073 -5 Lines 80126 80080 -46 ========================================== Hits 39576 39576 + Misses 40550 40504 -46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jbrichau commented 3 months ago

@kurtkilpela Thanks for this! I made another version that avoids a separate Gemstone-specific package in https://github.com/SeasideSt/Seaside/pull/1443

jbrichau commented 3 months ago

I'll close this and merge the other one.