Closed marschall closed 3 weeks ago
Attention: Patch coverage is 75.70093%
with 26 lines
in your changes missing coverage. Please review.
Project coverage is 50.03%. Comparing base (
0f7d6f7
) to head (f6be4f2
). Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is there a typo or two in https://github.com/marschall/Seaside/blob/master/repository/Seaside-WebComponents-Core.package/WAHeadlessComponent.class/README.md ?
Also, I wouldn't mind if the classes that are useful for SPA's are not buried, but more generally available. Perhaps in a SPA package?
Is there a typo or two in https://github.com/marschall/Seaside/blob/master/repository/Seaside-WebComponents-Core.package/WAHeadlessComponent.class/README.md ?
Probably a rendering issue by GitHub. Check out the raw content
Also, I wouldn't mind if the classes that are useful for SPA's are not buried, but more generally available. Perhaps in a SPA package?
What classes would you be interested in? WAWebComponentActionContinuation
? Do you have a suggestion for a name?
Perhaps in a SPA package?
Maybe, but only if we have more than one class to go there.
Got it. Thanks
What classes would you be interested in?
WAWebComponentActionContinuation
? Do you have a suggestion for a name?Perhaps in a SPA package?
Maybe, but only if we have more than one class to go there.
If I understand things correctly, i see
as candidates.
Maybe something like Seaside-SingleContinuation-Core as a name? Or maybe rename Seaside-WebComponents-Core as such?
Cheers, Adriaan.
Improvements that allow applications with Web Components to run with a lower overhead.
In theory these classes could be used in general for "back button less" Seaside applications. However this is quite an advanced topic so I think it's ok to "burry" these in the WebComponents package. Let me know what you think.