search

SeattleColleges / nsc-events-nextjs

NSC Events Web Application
MIT License
5 stars 5 forks source link

nsc-events-08-436-bug-create-new-event-required-field-logic-fix #480

Closed cshimm closed 4 months ago

cshimm commented 4 months ago

Resolves #436 This PR resolves the issue where the required field error persists even after the user fills in the field with the appropriate data.

https://github.com/SeattleColleges/nsc-events-nextjs/assets/13278479/cf30052e-aede-46b8-8ec6-5540f67ab0a5

Also here is a list of errors that don't appear as required field errors (the text fields aren't highlighted red) until clicking Submit. Adding the required field errors for these fields would be a different issue but once added, this PR should properly handle the required field errors once implemented. image

cshimm commented 4 months ago

@heosman I fixed the URL bugs with a URL regex pattern. It works but it might be better to use a library like 'validator' that does more robust form validation and is easier to read and use—just a thought.