search

SeattleTestbed / custominstallerbuilder

Django app to customize SeattleTestbed installers with public keys
MIT License
0 stars 7 forks source link

Base installers shouldn't be stored pre-compressed #12

Open aaaaalbert opened 9 years ago

aaaaalbert commented 9 years ago

packager.py takes the compressed base installers, unpacks them, adds an installer-specific vesselinfo file to the resulting tar file or directory and then re-compresses to create the final, downloadable installer.

However, storing the base installers in compressed form really only generates CPU and disk load, without solving any problems. Modifying the tar file did get us into trouble previously, see SeattleTestbed/custominstallerbuilder#9.

I therefore propose to store the base installers in uncompressed form, i.e. as plain directories, and only compress them as the last step of the packager.

JustinCappos commented 9 years ago

I think this may increase latency for a download. However, I do agree that is unlikely to be the most important thing and agree this change makes sense.

On Wed, Jul 8, 2015 at 11:47 AM, aaaaalbert notifications@github.com wrote:

packager.py https://github.com/SeattleTestbed/custominstallerbuilder/blob/master/common/packager.py takes the compressed base installers, unpacks them, adds an installer-specific vesselinfo file to the resulting tar file or directory and then re-compresses to create the final, downloadable installer.

However, storing the base installers in compressed form really only generates CPU and disk load, without solving any problems. Modifying the tar file did get us into trouble previously, see SeattleTestbed/custominstallerbuilder#9 https://github.com/SeattleTestbed/custominstallerbuilder/issues/9.

I therefore propose to store the base installers in uncompressed form, i.e. as plain directories, and only compress them as the last step of the packager.

— Reply to this email directly or view it on GitHub https://github.com/SeattleTestbed/custominstallerbuilder/issues/12.