Closed SemicolonExpected closed 4 years ago
I find the text a little confusing in the edit. Could you try to write more explicitly what you want them to do? Should the a and b files both disappear? Should file a still exist?
Maybe an example will help?
On Fri, Oct 9, 2020 at 5:21 AM Victoria Zhong notifications@github.com wrote:
I noticed somewhere along the way we lost the instruction to discard the backup and write to file after changes are saved to the original file. This also helps to clarify what the original file is, as if the a and b files are both discarded then they cannot be the original file
You can view, comment on, or merge this pull request online at:
https://github.com/SeattleTestbed/docs/pull/64 Commit Summary
- FIXED: Lost instruction
File Changes
- M EducationalAssignments/ABStoragePartOne.md https://github.com/SeattleTestbed/docs/pull/64/files#diff-23756ab45ab0a0779e4646374c73167d (2)
Patch Links:
- https://github.com/SeattleTestbed/docs/pull/64.patch
- https://github.com/SeattleTestbed/docs/pull/64.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SeattleTestbed/docs/pull/64, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGROD46PD5DZP5Q44QZ5X3SJYUPFANCNFSM4SJI2UCQ .
Is this more clear/ can this be improved further?
I noticed somewhere along the way we lost the instruction to discard the backup and write to file after changes are saved to the original file. This also helps to clarify what the original file is, as if the a and b files are both discarded then they cannot be the original file