search

SeattleTestbed / docs

Documentation for Seattle Testbed (scroll down for README)
MIT License
40 stars 164 forks source link

createlock() instead of getlock() #68

Open sam-maverick opened 4 years ago

sam-maverick commented 4 years ago

In the last sentence, it says "...In Repy use getlock() to create new instances..." It should say "createlock()", as it is the method referenced in the API (https://github.com/SeattleTestbed/docs/blob/master/Programming/RepyV2API.md)

JustinCappos commented 4 years ago

In the last line of what document? The RepyV1 call used to be named getlock(), so while unlikely it is possible this name might be "correct" (but misleading).

On Sun, Oct 25, 2020 at 6:45 AM sam-maverick notifications@github.com wrote:

In the last sentence, it says "...In Repy use getlock() to create new instances..." It should say "createlock()", as it is the method referenced in the API ( https://github.com/SeattleTestbed/docs/blob/master/Programming/RepyV2API.md )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SeattleTestbed/docs/issues/68, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRODYVAPLUTQKW46ELHWDSMNKJLANCNFSM4S54SXJA .

sam-maverick commented 4 years ago

Good morning! Sorry, I missed that info. It's in this document: https://github.com/SeattleTestbed/docs/blob/master/Programming/PythonVsRepy.md I actually tried to use getlock() in my code and it doesn't compile. With createlock() it works In this link https://github.com/SeattleTestbed/docs/blob/master/Programming/RepyV2API.md, it says that createlock() is based on threading.Lock() In this link https://github.com/SeattleTestbed/docs/blob/master/Programming/PythonVsRepy.md, it appears that getlock() is based on threading.Lock() So that's how I inferred the mistake, but of course I may be wrong because I'm new in Python :P I'm using Python 2.7.18rc1 (in case this is helpful info) Thanks!

Missatge de Justin Cappos notifications@github.com del dia dg., 25 d’oct. 2020 a les 9:50:

In the last line of what document? The RepyV1 call used to be named getlock(), so while unlikely it is possible this name might be "correct" (but misleading).

On Sun, Oct 25, 2020 at 6:45 AM sam-maverick notifications@github.com wrote:

In the last sentence, it says "...In Repy use getlock() to create new instances..." It should say "createlock()", as it is the method referenced in the API (

https://github.com/SeattleTestbed/docs/blob/master/Programming/RepyV2API.md )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SeattleTestbed/docs/issues/68, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAGRODYVAPLUTQKW46ELHWDSMNKJLANCNFSM4S54SXJA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SeattleTestbed/docs/issues/68#issuecomment-716151722, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ4USCWOLJVFGTSF3QEH2E3SMQUMDANCNFSM4S54SXJA .