SeattleTestbed / nodemanager

Remote control server for SeattleTestbed nodes
MIT License
0 stars 10 forks source link

update_crontab_entry.py not in RUNNABLE after running build.py #103

Closed yyzhuang closed 6 years ago

yyzhuang commented 9 years ago

When running unit test python utf.py -m nm, nodemanager log produced this error:

"The following error occured when modifying the crontab for the new 2009 seattle crontab entry: Traceback (most recent call last): File "nmmain.py", line 556, in main ImportError: No module named update_crontab_entry"

The file update_crontab_entry.py is located under /dist: https://github.com/SeattleTestbed/dist

After adding update_crontab_entry.py in RUNNABLE, this error disappears.

JustinCappos commented 9 years ago

Right. The logical fix may be to move it from dist to the node manager repo.

@aaaaalbert: do you foresee any problems with this?

On Sat, Jan 10, 2015 at 4:07 PM, Yanyan Zhuang notifications@github.com wrote:

When running unit test python utf.py -m nm, nodemanager log produced this error:

"The following error occured when modifying the crontab for the new 2009 seattle crontab entry: Traceback (most recent call last): File "nmmain.py", line 556, in main ImportError: No module named update_crontab_entry"

The file update_crontab_entry.py is located under /dist: https://github.com/SeattleTestbed/dist

After adding update_crontab_entry.py in RUNNABLE, this error disappears.

— Reply to this email directly or view it on GitHub https://github.com/SeattleTestbed/nodemanager/issues/103.

yyzhuang commented 9 years ago

Pull request: https://github.com/SeattleTestbed/nodemanager/pull/106

aaaaalbert commented 9 years ago

Sounds reasonable to me, although I would not expect too many pre-2009 Seattle crontab entries in the wild these days.

aaaaalbert commented 6 years ago

I chose to fix this problem by removing the check instead, 434ad0d9c8b8df2fe9102300ab4b03e1cfef97cd. Closing.