SeattleTestbed / nodemanager

Remote control server for SeattleTestbed nodes
MIT License
0 stars 10 forks source link

Improve logging if sandbox startup fails #121

Open aaaaalbert opened 8 years ago

aaaaalbert commented 8 years ago

When developing sandboxes that the nodemanager can control, it happens that things go wrong, and that spawning the sandbox results in an error. The current nmAPI.py doesn't handle this gracefully -- errors are simply ignored, and so a sandbox startup error results in

1, a mildly opaque error message in seash that the sandbox Did not start in a timely manner, but 2, no sign whatsover in the nodemanager log (which this issue proposes to fix).

Note that if you happen to start the sandbox directly from the command line (as opposed to through the nodemanager, i.e. usually seash), you will get to see any sandbox startup errors. Alas, you don't always get to launch a sandbox like this (think Android, see SeattleTestbed/utf#67), and even if you do, the startup code in nmAPI could still contain bugs.


So there! Let's make nmAPI collect any sandbox error output and send it to the nodemanager log