search

SeattleTestbed / nodemanager

Remote control server for SeattleTestbed nodes
MIT License
0 stars 10 forks source link

Fix nmAPI Repy filename checks exception handling #99

Closed aaaaalbert closed 9 years ago

aaaaalbert commented 9 years ago

It excepted TypeError's before, and thus never caught anything, resulting in the RepyArgumentError reaching callers like the nmrequesthandler (line 111) and missing clauses for the appropriate e errors. This would cause a nodemanager to report an "Internal Error" with no further details, as could be observed by uploading through seash a file conflicting with emulfile's filename checks (disallowed characters, name starting with "." or "private_", name too long).

Thanks go to Rohan Dalvi for reporting the issue!

JustinCappos commented 9 years ago

I'm not sure what the first or last commit have to do with this issue... Should they be in different PRs?

aaaaalbert commented 9 years ago

Hmm, seems I based the fix-nmAPI.... branch on the wrong commit. (The functionality in the two extraneous commits is in both master and fix-nmAPI, but not via the same parent commits.) Let me rebase and send the PR anew.