search

SeattleTestbed / repy_v2

Seattle Testbed's Repy ("Restricted Python") sandbox, version 2
MIT License
12 stars 50 forks source link

Adding security layer file #141

Closed el3232 closed 4 years ago

el3232 commented 4 years ago

Yes, I made a mistake by committing the changes to SeattleTestbed rather than my forked repository. I'm just learning git and github and would love to talk about how to think about adding the correct files. It was my understanding that while RUNNABLE should be built anew each time, I wasn't sure how to correctly reflect that the security layer should be in the RUNNABLE folder (if it should).

How can we discuss? Also, by closing the pull request, have I already "removed" all the files I added?

JustinCappos commented 4 years ago

Sure, that branch was not merged.

Can you tell me more about what you are hoping to accomplish with the pull request? What is the security layer you are adding for?

On Sun, Aug 9, 2020 at 12:45 PM el3232 notifications@github.com wrote:

Yes, I made a mistake by committing the changes to SeattleTestbed rather than my forked repository. I'm just learning git and github and would love to talk about how to think about adding the correct files. It was my understanding that while RUNNABLE should be built anew each time, I wasn't sure how to correctly reflect that the security layer should be in the RUNNABLE folder (if it should).

How can we discuss? Also, my closing the pull request, have I already "removed" all the files I added?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SeattleTestbed/repy_v2/pull/141#issuecomment-671074464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRODZHIOHPMJ7XU4B7AXTR73HCFANCNFSM4PZHZ5CQ .

el3232 commented 4 years ago

Essentially, I am adding the security layer as part of an ISP assignment. I wanted to contextualize it rather than just upload the single file. I want it to be something that would be more straight forward to use if someone wanted to (not that I expect them to).

Is there a best practice or a general assumption to follow with something like this? Again, I am new to this and am just trying to figure out how it would be in production/real world application.

JustinCappos commented 3 years ago

Sorry for the delayed response. Please look at your PR (pull request) and see if there are extra files added. I would pull and merge your files directly.

You can also use the view option on the pull request in order to see what the eventual files will look like.

On Tue, Aug 11, 2020 at 3:41 AM el3232 notifications@github.com wrote:

Essentially, I am adding the security layer as part of an ISP assignment. I wanted to contextualize it rather than just upload the single file. Is there a best practice or a general assumption to follow with something like this? Again, I am new to this and am just trying to figure out how it would be in production.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SeattleTestbed/repy_v2/pull/141#issuecomment-671550050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGROD24EDVDCXRLKMWJ2XTSABEOVANCNFSM4PZHZ5CQ .